Add CMake option for initializing all memory to 0#209
Open
Add CMake option for initializing all memory to 0#209
Conversation
Member
Author
|
I don't think the CI failure is related to my change. Looks like some build artifacts are not cleaned up correctly. |
Contributor
|
Would it be also useful to be able to initialize values to like the maximum of the range so you would trigger an overflow if not initialized? |
Member
Author
|
Are you thinking something like std::numeric_limits::max()? I like the idea, but it does get a little more complicated since the particular type is not available for the ArrayManager::allocate (it appears to be available for ArrayManager::reallocate, however). So either we would have to add the type for the ArrayManager::allocate call, or we would have to plumb this into the ManagedArray class itself. @davidbeckingsale, any ideas? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, it is desirable to have memory initialized to 0 (particularly for debugging). This option is controlled by passing CHAI_ENABLE_ZERO_INITIALIZED_MEMORY=ON to CMake. It is off by default to avoid imposing any overhead.