Skip to content

feat: adding idempotency to transfers #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pengying wants to merge 1 commit into
base: main
Choose a base branch
from
+56 −0
Open

feat: adding idempotency to transfers #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions openapi/paths/transfers/transfer_in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ post:
- Same-Currency Transfers
security:
- BasicAuth: []
parameters:
- name: Idempotency-Key
in: header
required: false
description: >
A unique identifier for the request. If the same key is sent multiple times,
the server will return the same response as the first request.
schema:
type: string
example: 550e8400-e29b-41d4-a716-446655440000
Comment on lines +13 to +21
Copy link

@greptile-apps greptile-apps bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing format constraint and maxLength. Consider adding validation to prevent abuse.

Suggested change
- name: Idempotency-Key
in: header
required: false
description: >
A unique identifier for the request. If the same key is sent multiple times,
the server will return the same response as the first request.
schema:
type: string
example: 550e8400-e29b-41d4-a716-446655440000
parameters:
- name: Idempotency-Key
in: header
required: false
description: >
A unique identifier for the request. If the same key is sent multiple times,
the server will return the same response as the first request.
schema:
type: string
maxLength: 255
Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/paths/transfers/transfer_in.yaml
Line: 13:21

Comment:
Missing format constraint and maxLength. Consider adding validation to prevent abuse.

```suggestion
  parameters:
    - name: Idempotency-Key
      in: header
      required: false
      description: >
        A unique identifier for the request. If the same key is sent multiple times,
        the server will return the same response as the first request.
      schema:
        type: string
        maxLength: 255
```

How can I resolve this? If you propose a fix, please make it concise.

requestBody:
required: true
content:
Expand Down
10 changes: 10 additions & 0 deletions openapi/paths/transfers/transfer_out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ post:
- Same-Currency Transfers
security:
- BasicAuth: []
parameters:
- name: Idempotency-Key
in: header
required: false
description: >
A unique identifier for the request. If the same key is sent multiple times,
the server will return the same response as the first request.
schema:
type: string
example: 550e8400-e29b-41d4-a716-446655440000
Comment on lines +11 to +19
Copy link

@greptile-apps greptile-apps bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing format constraint and maxLength. Consider adding validation to prevent abuse.

Suggested change
- name: Idempotency-Key
in: header
required: false
description: >
A unique identifier for the request. If the same key is sent multiple times,
the server will return the same response as the first request.
schema:
type: string
example: 550e8400-e29b-41d4-a716-446655440000
parameters:
- name: Idempotency-Key
in: header
required: false
description: >
A unique identifier for the request. If the same key is sent multiple times,
the server will return the same response as the first request.
schema:
type: string
maxLength: 255
Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/paths/transfers/transfer_out.yaml
Line: 11:19

Comment:
Missing format constraint and maxLength. Consider adding validation to prevent abuse.

```suggestion
  parameters:
    - name: Idempotency-Key
      in: header
      required: false
      description: >
        A unique identifier for the request. If the same key is sent multiple times,
        the server will return the same response as the first request.
      schema:
        type: string
        maxLength: 255
```

How can I resolve this? If you propose a fix, please make it concise.

requestBody:
required: true
content:
Expand Down