-
Notifications
You must be signed in to change notification settings - Fork 3
feat: adding API design guidelines #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryAdded comprehensive API design guidelines documentation to standardize API development practices across the Grid API. The documentation covers:
The guidelines accurately reflect the existing codebase patterns (verified against actual Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| openapi/README.md | Comprehensive API design guidelines documentation covering versioning, naming conventions, service patterns, pagination, error handling, and OpenAPI best practices |
Sequence Diagram
sequenceDiagram
participant Developer
participant OpenAPI Spec
participant Redocly CLI
participant Stainless
participant SDK
Developer->>OpenAPI Spec: Edit files in openapi/ directory
Note over Developer,OpenAPI Spec: Follow naming conventions<br/>Add descriptions & examples<br/>Define schemas & endpoints
Developer->>Redocly CLI: npm run build:openapi
Redocly CLI->>OpenAPI Spec: Bundle modular files
Redocly CLI->>OpenAPI Spec: Generate openapi.yaml
Developer->>Redocly CLI: npm run lint:openapi
Redocly CLI->>OpenAPI Spec: Validate schema
Redocly CLI-->>Developer: Report issues (if any)
Developer->>Stainless: Release SDK version
Stainless->>OpenAPI Spec: Read bundled spec
Stainless->>Stainless: Detect breaking changes
Stainless->>SDK: Generate SDK code
Note over Stainless,SDK: Auto-pagination support<br/>Type-safe errors<br/>Code examples
SDK-->>Developer: SDK with API reference examples
e9568b6 to
010dd68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| --- | ||
|
|
||
| ## Design Considerations | ||
| - Imagine you're teaching a customer how to use our API. How might you structure the API to make it easy to explain and understand? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: double space in "your API works"
| - Imagine you're teaching a customer how to use our API. How might you structure the API to make it easy to explain and understand? | |
| - Can integrators guess how your API works based on how other features work? |
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/README.md
Line: 12:12
Comment:
typo: double space in "your API works"
```suggestion
- Can integrators guess how your API works based on how other features work?
```
How can I resolve this? If you propose a fix, please make it concise.
TL;DR
Added API design guidelines documentation to standardize our API development practices.
What changed?
Created a comprehensive
README.mdin theopenapidirectory that outlines best practices for API design, including: