feat: add Quote/Transaction discriminators and remove inline examples

[pengying]

TL;DR

Refactored OpenAPI schema to use proper discriminators for polymorphic types in transaction and quote models.

What changed?

• Added proper discriminator fields (sourceType and destinationType) to polymorphic types in the API schema
• Extracted reusable schema components into separate files for better organization:
  • Created dedicated schema files for source and destination types (Account, UMA Address)
  • Added proper type discriminators to enable client code generation tools to handle polymorphism correctly
• Removed inline examples from the /quotes endpoint request body
• Removed redundant examples from schema definitions that were duplicated across multiple components

[pengying]

• feat: add Stainless SDK config and misc cleanups #132
• feat: rename Error to GridError and add additionalProperties to error schemas #131
• feat: add Customer API discriminators and consolidate customer changes #130
• feat: add Quote/Transaction discriminators and remove inline examples #129 👈 (View in Graphite)
• feat: add isPlatformAccount to PaymentInstructions and remove PaymentAccountOrWalletInfo refs #128
• feat: rename accounts to data in list external accounts response #127
• feat: convert single-value enums to const for base types #126
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR refactors the OpenAPI schema to implement proper discriminator patterns for polymorphic types across quotes and transactions.

Key Changes:

• Extracted inline schemas into reusable components (AccountSource, AccountDestination, UmaAddressDestination, UmaAddressSource, QuoteRealtimeFundingSource)
• Added discriminator fields (sourceType, destinationType, type) with proper mappings to enable code generators to handle polymorphism
• Removed inline examples from /quotes endpoint request body
• Added lint ignores for required at oneOf level per OpenAPI spec patterns

Impact:

• Improves code generation for client SDKs by providing explicit type discriminators
• Reduces duplication through schema extraction and reuse
• All discriminator mappings are consistent with their corresponding const values
• No breaking API changes - purely structural improvements to the schema definition

Note on Lint Ignores:
The required keyword at the oneOf level follows the OpenAPI spec example for discriminated polymorphism. While some linters flag this, it's a valid pattern for ensuring discriminator fields are present.

Confidence Score: 5/5

• This PR is safe to merge - it's a well-executed schema refactoring with no runtime impact
• All discriminator mappings are verified consistent with const values, schema extractions are clean and reusable, and the changes are purely structural improvements to OpenAPI definitions without affecting API behavior
• No files require special attention

Important Files Changed

Filename	Overview
openapi/components/schemas/common/AccountSource.yaml	New reusable schema for account funding source with ACCOUNT discriminator - clean extraction
openapi/components/schemas/common/AccountDestination.yaml	New reusable schema for account destination with ACCOUNT discriminator - clean extraction
openapi/components/schemas/quotes/QuoteSource.yaml	Refactored to use discriminator pattern with proper $refs instead of inline schemas
openapi/components/schemas/quotes/Quote.yaml	Added discriminator for destination oneOf - references extracted schemas
openapi/components/schemas/transactions/Transaction.yaml	Added discriminator for destination oneOf - references extracted schemas
.redocly.lint-ignore.yaml	Added lint ignores for required at oneOf level per OpenAPI spec recommendation

Sequence Diagram

sequenceDiagram
    participant Client
    participant API as Grid API
    participant Validator as Schema Validator
    participant CodeGen as Code Generator

    Note over Client,CodeGen: Quote Creation with Discriminated Source Types

    Client->>API: POST /quotes<br/>{source: {sourceType: "ACCOUNT", accountId: "..."},<br/>destination: {...}}
    API->>Validator: Validate request against QuoteRequest schema
    Validator->>Validator: Check source.sourceType discriminator
    alt sourceType == "ACCOUNT"
        Validator->>Validator: Validate against AccountSource.yaml
    else sourceType == "REALTIME_FUNDING"
        Validator->>Validator: Validate against QuoteRealtimeFundingSource.yaml
    end
    Validator->>API: Valid ✓
    API->>Client: 201 Quote Created

    Note over Client,CodeGen: Transaction Response with Discriminated Types

    Client->>API: GET /transactions/{id}
    API->>Client: 200 Transaction Response<br/>{type: "OUTGOING",<br/>source: {sourceType: "ACCOUNT", ...},<br/>destination: {destinationType: "UMA_ADDRESS", ...}}
    
    Client->>CodeGen: Deserialize response
    CodeGen->>CodeGen: Read type discriminator = "OUTGOING"
    CodeGen->>CodeGen: Map to OutgoingTransaction class
    CodeGen->>CodeGen: Read source.sourceType = "ACCOUNT"
    CodeGen->>CodeGen: Map to AccountSource class
    CodeGen->>CodeGen: Read destination.destinationType = "UMA_ADDRESS"
    CodeGen->>CodeGen: Map to UmaAddressDestination class
    CodeGen->>Client: Strongly-typed Transaction object

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}