Add commented-out patch section for LDK Git dependencies
#764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For convenience we added ready-to-go `patch` setions to `Cargo.toml`, which however only allowed us to quickly override official LDK releases. Here we also add the corrsponding counterparts for LDK `git` dependencies.
|
👋 Thanks for assigning @joostjager as a reviewer! |
joostjager
reviewed
Jan 21, 2026
| #vss-client-ng = { path = "../vss-client" } | ||
| #vss-client-ng = { git = "https://github.com/lightningdevkit/vss-client", branch = "main" } | ||
| # | ||
| #[patch."https://github.com/lightningdevkit/rust-lightning"] |
Contributor
There was a problem hiding this comment.
With multiple patch sections, idk if it is still better than just having a commented-out section in the regular location (no patch)?
Collaborator
Author
There was a problem hiding this comment.
It is. Note that patch is fundamentally different in that it will transitively patch the dependency for all sub-dependencies. So if you patch in LDK Node, you won't need to have it point to a changed version of bitcoin-payments-instruction also pointing to the same LDK dependency, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #758.
For convenience we added ready-to-go
patchsetions toCargo.toml, which however only allowed us to quickly override official LDK releases.Here we also add the corrsponding counterparts for LDK
gitdependencies.