Some PETSc vector modifications #4374
Open
+11
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code path that used to exist after the `operator=` branch is incredibly non-performant. It led to a serial GPU run running 20% slower on residual evaluations than a 30 rank CPU run. After its removal, the GPU run residual evaluation is 3 times faster. That's how large the performance penalty is
roystgnr
requested changes
Jan 26, 2026
Member
roystgnr
left a comment
roystgnr
left a comment
There was a problem hiding this comment.
All I can find is that one assertion failing - and that's probably an overzealous assertion with any PETSc version that's not so ancient we stopped supporting it a decade ago? I'd try just removing it and see what happens.
| LibmeshPetscCall(VecCopy(_vec,v_local->_vec)); | ||
| else | ||
| libmesh_error_msg("Vectors are inconsistent"); | ||
| libmesh_assert(this->comm().verify(int(this->type()))); |
Member
There was a problem hiding this comment.
To satisfy my OCD: could we use std::underlying_type<ParallelType>::type instead of int here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be interested to see whether the
localizechanges break stuff. I bet it will at least break unit testing but it will be more interesting to see whether it breaks production code