Fully clearing out all deprecated infra dirs #5676
Open
+0
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initially put in place during #5596
The idea being that the CD pipelines wouldn't have to updated on the infra side in coordination with the merge of this PR.
But it didn't work:
David Cañas [3:21 PM]
I actually added symlinks specifically to avoid having to do this
David Cañas [3:30 PM]
Oh. Just got to look at the error message.The problem here is that it is docker inside of docker and docker does not like sym links
twice
Marcella Maki [4:14 PM] @david the build failed and I don't know if it's me
if this is a larger issue it does not need to be remediated right now, it's fine.
David Cañas [4:24 PM]
I had this lined up yesterday, and then was like "nahhh they're not merging it up yet and I might brake build for any other changes" and then completely forgot when you told me you were merging up
References
Resolves https://github.com/learningequality/infrastructure/issues/660
Reviewer guidance
Enjoy the red 🤩