Skip to content

[Remove Vuetify from Studio] Cards in Content Library #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vtushar06 wants to merge 10 commits into
base: channel-cards
Choose a base branch
from
+228 −164
Open

[Remove Vuetify from Studio] Cards in Content Library #5616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7000d7f
added StudioCatalogList.vue following past PRs
vtushar06 Dec 19, 2025
ded9d8a
fixed UI for select button
vtushar06 Dec 19, 2025
90b6ac2
fixed import in router for StudioCatalogList
vtushar06 Dec 19, 2025
933bd8a
Added Checkbox in StudioChannalCaard with select slot
vtushar06 Dec 19, 2025
524b4cf
changes unit tests frron test-utils to vue testing library
vtushar06 Dec 19, 2025
be36934
update import for CatalogList component in router
vtushar06 Dec 19, 2025
5048ea6
replace Checkbox with KCheckbox and update selection logic in Catalog…
vtushar06 Dec 19, 2025
a52562b
remove StudioCatalogList component and its associated styles
vtushar06 Dec 19, 2025
99d1711
rename StudioCatalogList to CatalogList in tests
vtushar06 Dec 19, 2025
0cc3d1d
remove data-testid
vtushar06 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 38 additions & 27 deletions contentcuration/contentcuration/frontend/channelList/views/Channel/CatalogList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,36 +43,38 @@
<KButton
v-if="page.count && !selecting"
:text="$tr('selectChannels')"
data-testid="select"
data-test="select"
Copy link
Member

@MisRob MisRob Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to change testid. Perhaps just merge conflict?

appearance="basic-link"
@click="setSelection(true)"
/>
<Checkbox
<KCheckbox
v-else-if="selecting"
v-model="selectAll"
class="mb-4 mx-2"
:indeterminate="isIndeterminate"
:label="$tr('selectAll')"
:indeterminate="selected.length > 0 && selected.length < channels.length"
class="mb-4 mx-2"
/>
</VFlex>
<VFlex xs12>
<VLayout
v-for="item in channels"
:key="item.id"
align-center
<KCardGrid
layout="1-1-1"
:skeletonsConfig="[
Copy link
Member

@MisRob MisRob Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're not yet passing loading state to card grid, it will never show loading skeletons, and therefore skeletonsConfig is not needed.

We will probably use loading skeletons, but that'd be outside of scope of this task, so let's remove.

{
breakpoints: [0, 1, 2, 3, 4, 5, 6, 7],
orientation: 'vertical',
count: 3,
},
]"
>
<Checkbox
v-show="selecting"
v-model="selected"
class="mx-2"
:value="item.id"
<StudioChannelCard
v-for="channel in channels"
:key="channel.id"
:channel="channel"
:selectable="selecting"
:selected="isChannelSelected(channel.id)"
@toggle-selection="handleSelectionToggle"
/>
<ChannelItem
:channelId="item.id"
:detailsRouteName="detailsRouteName"
style="flex-grow: 1; width: 100%"
/>
</VLayout>
</KCardGrid>
</VFlex>
<VFlex
xs12
Expand Down Expand Up @@ -135,27 +137,25 @@
import useKResponsiveWindow from 'kolibri-design-system/lib/composables/useKResponsiveWindow';
import { RouteNames } from '../../constants';
import CatalogFilters from './CatalogFilters';
import CatalogFilterBar from './CatalogFilterBar';
import ChannelItem from './ChannelItem';
import LoadingText from 'shared/views/LoadingText';
import Pagination from 'shared/views/Pagination';
import BottomBar from 'shared/views/BottomBar';
import Checkbox from 'shared/views/form/Checkbox';
import ToolBar from 'shared/views/ToolBar';
import OfflineText from 'shared/views/OfflineText';
import { constantsTranslationMixin } from 'shared/mixins';
import { channelExportMixin } from 'shared/views/channel/mixins';
import CatalogFilterBar from './CatalogFilterBar';
import StudioChannelCard from './components/StudioChannelCard';

export default {
name: 'CatalogList',
components: {
ChannelItem,
StudioChannelCard,
LoadingText,
CatalogFilters,
CatalogFilterBar,
Pagination,
BottomBar,
Checkbox,
ToolBar,
OfflineText,
},
Expand Down Expand Up @@ -216,9 +216,6 @@
debouncedSearch() {
return debounce(this.loadCatalog, 1000);
},
detailsRouteName() {
return RouteNames.CATALOG_DETAILS;
Copy link
Member

@MisRob MisRob Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for removing this part?

Copy link
Contributor Author

@vtushar06 vtushar06 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unused code that wasn't passed to StudioChannelCard.
The new component handles its own routing.
should it must be there??

Copy link
Member

@MisRob MisRob Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That depends if the change affects user experience - you may want to check before/after. Is the route same as the one in StudioChannelCard?

Copy link
Member

@MisRob MisRob Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any observations on the above?

},
channels() {
// Sort again by the same ordering used on the backend - name.
// Have to do this because of how we are getting the object data via getChannels.
Expand All @@ -227,6 +224,9 @@
selectedCount() {
return this.page.count - this.excluded.length;
},
isIndeterminate() {
return this.selected.length > 0 && this.selected.length < this.channels.length;
},
},
watch: {
$route(to) {
Expand All @@ -250,6 +250,17 @@
},
methods: {
...mapActions('channelList', ['searchCatalog']),
isChannelSelected(channelId) {
return this.selected.includes(channelId);
},
handleSelectionToggle(channelId) {
const currentlySelected = this.selected;
if (currentlySelected.includes(channelId)) {
this.selected = currentlySelected.filter(id => id !== channelId);
} else {
this.selected = [...currentlySelected, channelId];
}
},
loadCatalog() {
this.loading = true;
const params = {
Expand Down
Loading