fix: rewire cell2mol dependency in requirements and pyproject#119
fix: rewire cell2mol dependency in requirements and pyproject#119
Conversation
6a7ec1b to
e56ee0b
Compare
|
I thought we removed |
|
also cell2mol's requirements are incompatible with ours i think https://github.com/lcmd-epfl/cell2mol/blob/40b32372d9a922afcf3e73c29df0430cf624508c/pyproject.toml |
e56ee0b to
35a5ab2
Compare
|
have you checked if 3.9 and 3.11 installations work? |
|
also are you sure we need docs-build in all? |
|
er- |
|
...also I could have sworn I removed those new git commit IDs from the changes |
|
ok, so the new cell2mol commit is incompatible with python itself (due to the syntax of some recent type annotations) |
35a5ab2 to
77d08d0
Compare
|
@liam-o-marsh so nothing works now... should we just drop 3.9? |
|
py3.11 passes all the tests |
oh i know how to fix this |
|
okay I can redefine |
|
okay I can fix a lot of thing but not cell2mol |
Co-authored by: Liam Marsh <liam.marsh@epfl.ch> Co-authored by: Ksenia Briling <ksenia.briling@epfl.ch>
|
shall we keep python 3.9 compatibility fix ugly hacks of 4072f82? @liam-o-marsh @YAY-C |
|
hm... |
|
okay! shall we merge this then? |
and also removed docs/build from the repo? not sure why it was there in the first place, but I can't remember if we were supposed to remove it eitheredit: this is no longer the case now that it has been rebased