fix: Add missing devDependencies for DTS build and fix GoogleIcon type error #1235
+21
−716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on textAnchor type error
Copilot
AI
changed the title
[WIP] Fix action run issue in Sistent
fix: Add missing devDependencies for DTS build and fix GoogleIcon type error
Jan 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI build failure in the DTS (TypeScript declaration) generation workflow. The issue occurred because peer dependencies (xstate and @meshery/schemas) were not available during the build process, causing module resolution failures. Additionally, it corrects an invalid SVG attribute in the GoogleIcon component.
Changes:
- Added
xstateand@meshery/schemasto devDependencies to ensure they're installed during CI builds - Removed invalid
textAnchor="none"attribute from<g>elements in GoogleIcon.tsx (this attribute is only valid for<text>elements) - Updated package-lock.json to reflect the dependency changes
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/icons/Google/GoogleIcon.tsx | Removed invalid textAnchor attribute from two <g> elements |
| package.json | Added xstate and @meshery/schemas to devDependencies with versions matching peerDependencies |
| package-lock.json | Updated dependency tree to reflect the new devDependencies configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflow failed because
xstateand@meshery/schemasare peer dependencies not available during build, causing TypeScript declaration generation to fail withCannot find module 'xstate'.Changes
xstateand@meshery/schemastodevDependencies(same versions as peerDependencies) so they're installed during CI buildtextAnchor="none"attribute —"none"is not a valid SVG text-anchor value, and this error was masked by the earlier module resolution failureThe DTS build now completes successfully:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.