Skip to content

fix: Step9 eval mode #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HongleiGu merged 1 commit into from
Feb 1, 2026
Merged

fix: Step9 eval mode #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions evaluation_function/correction/correction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,16 @@ def analyze_fsa_correction(
# Step 9: Decide correctness based on evaluation mode
# -------------------------------------------------------------------------
if params.evaluation_mode == "strict":
is_correct = validation_result is not None and validation_result.ok and equivalence_result.ok and iso_result.ok
is_correct = (
(not params.check_minimality or validation_result.ok)
and equivalence_result.ok
and iso_result.ok
)
elif params.evaluation_mode == "lenient":
is_correct = validation_result is not None and validation_result.ok and equivalence_result.ok
is_correct = (
(not params.check_minimality or validation_result.ok)
and equivalence_result.ok
)
else: # partial # I dont know what the partial is meant for, always mark as incorrect?
is_correct = False

Expand Down