Skip to content

fix: check param state #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HongleiGu merged 1 commit into from
Jan 31, 2026
Merged

fix: check param state #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion evaluation_function/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,17 @@ def evaluation_function(
Returns:
LFResult with is_correct and feedback_items
"""
return LFResult(
is_correct=False,
feedback_items=[(
"error",
f"Invalid FSA format: {str(e)}\n\n"
f"response: {response}\nanswer: {answer}\nparams: {params}"
)]
)
try:
# TEMPORARY WORKAROUND: Extract from params if not passed directly

if params is None:
params = {}

Expand Down Expand Up @@ -59,7 +68,7 @@ def evaluation_function(
# Return LFResult
return LFResult(
is_correct=result.is_correct,
feedback_items=[("result", result.feedback), ("errors", result.fsa_feedback.model_dump_json())]
feedback_items=[("result", result.feedback), ("errors", result.fsa_feedback.model_dump_json()), ("input", {"answer": answer, "response": response, "params": params})]
)

except Exception as e:
Expand Down