-
Notifications
You must be signed in to change notification settings - Fork 966
start managing azure infra with terraform #8974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment has been minimized.
This comment has been minimized.
ab49a22 to
6a013be
Compare
This comment has been minimized.
This comment has been minimized.
6a013be to
ba08330
Compare
Argo CD Diff PreviewSummary: Total: 2 files changed
Modified (2):
± aks-prow-build (+16)
± atlantis (+21)aks-prow-build (kubernetes/apps/prow.yaml)@@ Application modified: aks-prow-build (kubernetes/apps/prow.yaml) @@
}
}
kind: ConfigMap
metadata:
name: google-adc
namespace: test-pods
---
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+ annotations:
+ azure.workload.identity/client-id: 333bb18b-207b-4abd-9ed0-e7e3834378b1
+ name: azure
+ namespace: test-pods
+---
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+ annotations:
+ azure.workload.identity/client-id: f23f8fcc-855b-40fd-a41b-b329ccdb95a1
+ name: rg-cleanup
+ namespace: test-pods
+---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
api-approved.kubernetes.io: https://github.com/kubernetes-sigs/boskos/pull/105
name: dynamicresourcelifecycles.boskos.k8s.io
spec:atlantis (kubernetes/apps/atlantis.yaml)@@ Application modified: atlantis (kubernetes/apps/atlantis.yaml) @@
- env:
- name: AWS_ROLE_ARN
value: arn:aws:iam::348685125169:role/atlantis
- name: AWS_WEB_IDENTITY_TOKEN_FILE
value: /var/run/secrets/aws-iam-token/serviceaccount/token
- name: AWS_REGION
value: us-east-2
+ - name: ARM_USE_AKS_WORKLOAD_IDENTITY
+ value: "true"
+ - name: ARM_SUBSCRIPTION_ID
+ value: 46678f10-4bbb-447e-98e8-d2829589f2d8
+ - name: AZURE_CLIENT_ID
+ value: 6fe87cee-6470-45d8-accc-57687193e504
+ - name: AZURE_FEDERATED_TOKEN_FILE
+ value: /var/run/secrets/azure-token/serviceaccount/token
+ - name: AZURE_TENANT_ID
+ value: d1aa7522-0959-442e-80ee-8c4f7fb4c184
- name: ATLANTIS_CONFIG
value: /config/atlantis.yaml
- name: ATLANTIS_GH_TOKEN
valueFrom:
secretKeyRef:
key: token
name: atlantis-vcs
@@ skipped 32 lines (41 -> 72) @@
memory: 1Gi
volumeMounts:
- mountPath: /config
name: config
- mountPath: /var/run/secrets/aws-iam-token/serviceaccount
name: aws-iam-token
readOnly: true
+ - mountPath: /var/run/secrets/azure-token/serviceaccount
+ name: azure-token
+ readOnly: true
- mountPath: /atlantis
name: atlantis-data
securityContext:
fsGroup: 1000
serviceAccountName: atlantis
volumes:
- configMap:
name: atlantis-config-4mc949mdm2
name: config
- name: aws-iam-token
projected:
defaultMode: 420
sources:
- serviceAccountToken:
audience: sts.amazonaws.com
+ expirationSeconds: 86400
+ path: token
+ - name: azure-token
+ projected:
+ defaultMode: 420
+ sources:
+ - serviceAccountToken:
+ audience: api://AzureADTokenExchange
expirationSeconds: 86400
path: token
updateStrategy:
rollingUpdate:
partition: 0
type: RollingUpdate
volumeClaimTemplates:Stats: |
|
atlantis plan |
This comment has been minimized.
This comment has been minimized.
|
atlantis plan |
This comment has been minimized.
This comment has been minimized.
|
atlantis plan |
This comment has been minimized.
This comment has been minimized.
|
atlantis plan |
This comment has been minimized.
This comment has been minimized.
|
atlantis plan |
|
Ran Plan for dir: Plan Error Show Output |
This PR introduces a few changes: