Skip to content

Fix ibmcloud-secret-rotator CLI to apply --region before instance #8954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sudharshanibm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ibmcloud-secret-rotator CLI to apply --region before instance #8954

sudharshanibm wants to merge 1 commit into from
+5 −1

Conversation

@sudharshanibm
Copy link
Contributor

@sudharshanibm sudharshanibm commented Jan 16, 2026

This change fixes an issue where the ibmcloud-secret-rotator CronJob was attempting to contact the us-south Secrets Manager endpoint, even though the Secrets Manager instance is provisioned in eu-de, causing repeated DNS resolution failures.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 16, 2026

Hi @sudharshanibm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 16, 2026
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2026
mkumatag
mkumatag approved these changes Jan 17, 2026
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, sudharshanibm, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sudharshanibm
Fix ibmcloud-secret-rotator CLI to apply --region before instance res…
2ce245d 
…olution

This change fixes an issue where the ibmcloud-secret-rotator CronJob was attempting to contact the us-south Secrets Manager endpoint, even though the Secrets Manager instance is provisioned in eu-de, causing repeated DNS resolution failures.
Signed-off-by: Sudharshan Muralidharan <sudharshan.muralidharan1@ibm.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 19, 2026

New changes are detected. LGTM label has been removed.

@k8s-infra-ci-robot
Copy link
Contributor

k8s-infra-ci-robot commented Jan 19, 2026

Argo CD Diff Preview

Summary:

No changes found

No changes found

Stats:
[Applications: 6], [Full Run: 1m44s], [Rendering: 47s], [Cluster: 24s], [Argo CD: 32s]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@upodroid upodroid upodroid approved these changes

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

+1 more reviewer

@mkumatag mkumatag mkumatag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mkumatag mkumatag

@upodroid upodroid

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sudharshanibm @k8s-ci-robot @k8s-infra-ci-robot @mkumatag @upodroid