Skip to content

Conversation

@sudharshanibm
Copy link
Contributor

@sudharshanibm sudharshanibm commented Jan 13, 2026

Changes Made:

  • k8s-s390x-conformance from 4hrs to 12hrs to better align with required secret rotation policies.
  • Added --region eu-de flag and IBMCLOUD_REGION=eu-de environment variable to ensure the CLI uses the correct regional endpoint.

Reason for these changes:

While debugging recent failures in the ibmcloud-secret-rotator cronJob, noticed that the Secrets Manager CLI was defaulting to the us-south endpoint, even though the Secrets Manager instance is provisioned in eu-de

This resulted in DNS resolution failures like:

go: downloading github.com/go-playground/locales v0.14.1
Error: Get "https://0664d47c-fe42-423f-930d-69570443cd15.us-south.secrets-manager.appdomain.cloud/api/v2/secrets?limit=10&match_all_labels=rotate%3Atrue&secret_types=iam_credentials": dial tcp: lookup 0664d47c-fe42-423f-930d-69570443cd15.us-south.secrets-manager.appdomain.cloud on 10.96.0.10:53: no such host

the CronJob and Helm config already assume eu-de, but the CLI falls back to us-south unless explicitly specified.

@k8s-ci-robot
Copy link
Contributor

Hi @sudharshanibm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2026
@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 13, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2026
@k8s-infra-ci-robot
Copy link
Contributor

k8s-infra-ci-robot commented Jan 16, 2026

Argo CD Diff Preview

Summary:

No changes found

No changes found

Stats:
[Applications: 6], [Full Run: 1m45s], [Rendering: 47s], [Cluster: 24s], [Argo CD: 32s]

@sudharshanibm sudharshanibm force-pushed the ttl-update branch 2 times, most recently from 9a13f43 to 408b736 Compare January 16, 2026 09:17
k8s-s390x-conformance from 4hrs to 12hrs to better align with required secret rotation policies
Signed-off-by: Sudharshan Muralidharan <sudharshan.muralidharan1@ibm.com>
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sudharshanibm, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
@k8s-ci-robot k8s-ci-robot merged commit 4954bf0 into kubernetes:main Jan 16, 2026
5 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants