-
Notifications
You must be signed in to change notification settings - Fork 966
Update TTL for prow_secret in secrets manager modules #8940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @sudharshanibm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d2971c6 to
2e76afa
Compare
Argo CD Diff PreviewSummary: No changes foundNo changes found Stats: |
9a13f43 to
408b736
Compare
k8s-s390x-conformance from 4hrs to 12hrs to better align with required secret rotation policies Signed-off-by: Sudharshan Muralidharan <sudharshan.muralidharan1@ibm.com>
408b736 to
79fe527
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sudharshanibm, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes Made:
--region eu-deflag and IBMCLOUD_REGION=eu-de environment variable to ensure the CLI uses the correct regional endpoint.Reason for these changes:
While debugging recent failures in the
ibmcloud-secret-rotatorcronJob, noticed that the Secrets Manager CLI was defaulting to theus-southendpoint, even though the Secrets Manager instance is provisioned ineu-deThis resulted in DNS resolution failures like:
the CronJob and Helm config already assume
eu-de, but the CLI falls back tous-southunless explicitly specified.