Added support for explicit-boundary blank maps#8
Open
maxvonhippel wants to merge 4 commits intokomoot:masterfrom
Open
Added support for explicit-boundary blank maps#8maxvonhippel wants to merge 4 commits intokomoot:masterfrom
maxvonhippel wants to merge 4 commits intokomoot:masterfrom
Conversation
Author
Contributor
|
Thanks @maxvonhippel for this request, I haven't seen it earlier that's why I respond that late. I can understand your use case and I am sure others will need this feature too. however I think there is an easier approach to accomplish it, with the features already implemented in this library. Only a tiny change is needed see #10 Do you think this would work out for you too? |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now create blank maps by setting an explicit extent. To be clear, I have only added explicit extent support for blank maps. Non-blank ones are more difficult (and frankly not a feature I currently need), but if someone else wants to give it a go I'm sure it would be a good feature to have.
Here is an example, which I tested and which works: