Refactor Code to Address Implementation and Design Smells#885
Open
bindumalavika wants to merge 6 commits intoknowm:developfrom
Open
Refactor Code to Address Implementation and Design Smells#885bindumalavika wants to merge 6 commits intoknowm:developfrom
bindumalavika wants to merge 6 commits intoknowm:developfrom
Conversation
…tegoryChartBuilder class
Member
|
I will review soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Smells
1. Extracted Method
Removed duplicate code by applying the Extract Method refactoring technique.
2. Decomposed Conditional Logic
Simplified a complex conditional block by applying the Decompose Conditional refactoring technique.
3. Introduced Explaining Variable
Improved readability and maintainability by introducing explaining variables to clarify complex expressions and reduce cognitive load in the code.
Design Smells
4. Removed Design Smell in CategoryChartBuilder
Refactored the code to create the CategoryChart object within the CategoryChartBuilder class.
5. Moved getBoundsHint Method
Refactored the getBoundsHint method from the ChartTitle class to the Chart class.
6.Extracted Class
Removed unrelated responsibilities from DemoChartsUtil by applying the Extract Class refactoring technique.