Open
Conversation
de87c58 to
c3c3018
Compare
Author
|
Hmm, with mpq.c does not work as supposed. Without the header GCC complains: However if the header is added, it fails: |
Author
|
For now, I have dropped the change from mpq.c. It leaves the bug there, but since adding header creates a conflict, something else should be done. Other ones work neatly. |
12 tasks
Author
|
@kfl Could you review this, please? |
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to partly address this failure: #71
It seems that these headers were simply forgotten here, since other files add them when related functions are used.