Add new parameter to choose between BAM and RTS for Transport Protocol#97
Open
hezy0426 wants to merge 1 commit intojuergenH87:masterfrom
Open
Add new parameter to choose between BAM and RTS for Transport Protocol#97hezy0426 wants to merge 1 commit intojuergenH87:masterfrom
hezy0426 wants to merge 1 commit intojuergenH87:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #96. We can't manually choose between BAM or RTS for the transport protocol because it's chosen for us based on the PF value. This PR adds a new parameter to send_pgn() function so that users can choose which TP method to use. This is a default parameter that only matters when the data is more than 8.