Open
Conversation
Owner
|
Looks promising but can you make the update at the template level ? All the files in |
Owner
|
To verify, make your edits in the templates folder and run |
jrottenberg
requested changes
Oct 12, 2025
| LIBVMAF = {"version": "3.0.0", "release_date": "2023-12-07"} | ||
| # libvmaf to old for cuda we need use master branch | ||
| # https://github.com/Netflix/vmaf/issues/1357 | ||
| LIBVMAF = {"version": "master", "release_date": "2023-12-07"} |
Owner
There was a problem hiding this comment.
I can't got with a branch name, even master, it should be a tag, the project is active I wonder why they are not publishing a tag at least !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #416
Because of Netflix/vmaf#1357 - we take master branch of vmaf