[JENKINS-24208] Allow to bann a pusher to avoid triggering loop when your job is push…

[ouaibsky]

…ing to github
banned user can be set at plugin configuration (jenkins admin)
Can be probably enhanced by

• accepting a list of users
• move per job configuration

But good enough as a first shot.

It's my first time in jenkins plateform and groovy, let me know what can be improved

---

This change is

[acejam]

My team could also significantly benefit from this. This is a critical setting in any true CI/CD workflow. Please let me know what's needed to help move this along, and I'll try to do the work.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@b82a666). Click here to learn what that means.
The diff coverage is 75.74%.

@@            Coverage Diff            @@
##             master      #83   +/-   ##
=========================================
  Coverage          ?   75.07%           
=========================================
  Files             ?       64           
  Lines             ?     1424           
  Branches          ?      147           
=========================================
  Hits              ?     1069           
  Misses            ?      309           
  Partials          ?       46

Impacted Files	Coverage Δ
...va/com/coravy/hudson/plugins/github/GithubUrl.java	92.3% <ø> (ø)
...ugins/github/internal/GHPluginConfigException.java	0% <0%> (ø)
...insci/plugins/github/admin/RequireAdminRights.java	0% <0%> (ø)
...nsci/plugins/github/admin/RespondWithRedirect.java	0% <0%> (ø)
...hub/extension/status/GitHubStatusResultSource.java	100% <100%> (ø)
...ins/github/extension/status/GitHubReposSource.java	100% <100%> (ø)
...enkinsci/plugins/github/webhook/GHEventHeader.java	100% <100%> (ø)
...ava/org/jenkinsci/plugins/github/GitHubPlugin.java	100% <100%> (ø)
...ub/extension/status/GitHubStatusContextSource.java	100% <100%> (ø)
...coravy/hudson/plugins/github/GithubLinkAction.java	100% <100%> (ø)
... and 54 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82a666...83cb0cb. Read the comment docs.

[eBeyond]

As the github plugin is used in jenkins pipeline it's no way to use a decider or any other things. It's even not possible to configure git-plugin for ignoring builds (as it also not works with github-webhooks). So you run into a loop if the job is pushing into the same repo.
As far as I can see it's also not a job of the git-plugin to evaluate the webhook of github to decide if a build is run. It's up to the github-plugin, as the main reason of this plugin, to decide to trigger a build or not.

[slavakl]

Hello!
Is there any progress on this? We use GitHub Organization Folder Plugin and can't neither configure git-scm nor use decider to prevent a loop. We have to check committer at the beginning of pipeline, which works fine, however it create "empty" build runs that totally messes up statistics. Moreover, we have to unnecessarily clone repository in order to understand whether build needs to be skipped. Would be much cleaner to do it based on payload info

[lanwen]

Hello, im working on proper implementation of the brand new SCMEventApi with Github as a source. Can't provide any estimates, but it should solve filtering problem.

[ctoestreich]

@slavakl @lanwen We are in the same exact boat. Using the GitHub Organization Folder Plugin is great... except we tag and push and get build loops. @slavakl How are you checking for user on commit, i have tried several methods and have not come up with a reliable method.