Skip to content

fix: expand env vars & token macros in manually entered repo urls for commit status#317

Open
jwbrandon wants to merge 2 commits intojenkinsci:masterfrom
jwbrandon:fix/expand-manual-repository-variables
Open

fix: expand env vars & token macros in manually entered repo urls for commit status#317
jwbrandon wants to merge 2 commits intojenkinsci:masterfrom
jwbrandon:fix/expand-manual-repository-variables

Conversation

@jwbrandon
Copy link

@jwbrandon jwbrandon commented Dec 7, 2022

Expand environment variables & token macros in manually entered repository urls for commit status

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jwbrandon jwbrandon force-pushed the fix/expand-manual-repository-variables branch 4 times, most recently from 66838fe to d5857b2 Compare December 8, 2022 18:27
@jwbrandon jwbrandon force-pushed the fix/expand-manual-repository-variables branch from d5857b2 to 830ded9 Compare December 8, 2022 19:23
@karimMourra
Copy link

This is great! Can we get this merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants