[JENKINS-49332] Better error messages#225
Conversation
when github repo webhook can't be created Don't throw exceptions as we are handling the error, just print to the log
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
This would really be useful, as I get these stack traces all the time. Would a cleaned-up version of this PR be welcome @KostyaSha?
|
|
||
| import com.cloudbees.jenkins.GitHubRepositoryName; | ||
| import com.google.common.base.Function; | ||
| import com.google.common.base.Optional; |
There was a problem hiding this comment.
Seems to be a compilation error.
I were waiting user to fixup #226 but any working variant will be ok |
Fix compilation and tests
|
I think I forgot to come back to finish this. |
|
CI failing with not enough space on disk |
Ah, even better to not have to show an error at all because we never try to do something we are not permitted to do. |
if we don't have admin permissions
|
I've changed it to not show the problem if there are no permissions, lowered the log level to debug and added more testing |
|
About #226 - sorry I fell out of the loop, hope to get back to that soon. Or feel free to follow up with PRing wanted cleanups on top of that :) |
|
Can this one be merged? We have hundreds of repos adding the stacktrace to the log. It would be very nice to get that fixed. |
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Looks fine. Have not tested it.
|
yes it is done |
5 participants
when github repo webhook can't be created
Don't throw exceptions as we are handling the error, just print to the log
This change is