JENKINS-72894 - Adding support to more than 1000 repositories#773
Open
guilhermemotadock wants to merge 5 commits intojenkinsci:masterfrom
Open
JENKINS-72894 - Adding support to more than 1000 repositories#773guilhermemotadock wants to merge 5 commits intojenkinsci:masterfrom
guilhermemotadock wants to merge 5 commits intojenkinsci:masterfrom
Conversation
jglick
previously requested changes
Mar 19, 2024
jglick
dismissed
their stale review
addressed (I am not reviewing code changes at this time)
rsandell
reviewed
Mar 21, 2024
|
|
||
| // Only the first 1000 search results are available | ||
| if (ghRepositorySearchBuilder.list().getTotalCount() > 1000) { | ||
| return org.listRepositories(100); |
Member
There was a problem hiding this comment.
Looks to me like this is ignoring all the search settings above.
There is also redundant code in these two new methods that can be reduced.
Author
There was a problem hiding this comment.
Hello, the query above only returns the first 1000 records. This is a github limitation.
The query also returns the number of existing records and this value is used to make a decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding support to more than 1000 repositories. See
JENKINS-72894 for further information.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify