Upgrade to use jcasc test harness#266
Conversation
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
All this seems reasonable to me.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>jackson2-api</artifactId> |
There was a problem hiding this comment.
Curious as to why a new dependency needs to be introduced.
There was a problem hiding this comment.
github-api-plugin depends on this plugin, so it's not really adding a new dep, but the released version is very out-dated (causing enforcer errors).
If someone wants to release github-api-plugin then this dependency change is unneeded
There was a problem hiding this comment.
jenkinsci/github-api-plugin#35 is going to remove this dependency. Hopefully that gets released and you can just depend on the new version. @bitwiseman are you planning a new release soon?
There was a problem hiding this comment.
right, there shouldn't be a conflict anymore and then this dependency could be removed
There was a problem hiding this comment.
@res0nance
I'm planning to release as soon as I reasonably can, in the meanwhile. I'll take this PR as it stands.
5 participants
JCasc had to create a new dependency that wasn't a
testsclassifier because maven doesn't allow you to bring dependencies through classifiers.Upgrading here so that PCT works again,
Tracking:
jenkinsci/bom#164
Note: We'll need a release for PCT please