Add appendix discussing recursive variants#611
Merged
Conversation
zhihaoy
reviewed
Nov 6, 2025
zhihaoy
left a comment
There was a problem hiding this comment.
Yea, but none of these matters. Deleting it, putting std::indirect with operator T& in the type traits in this file, and everything works as before, because neither type is exposed in the interface. It's the saved effort of modeling operations via meta-programming matters.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 99.51% 98.71% -0.81%
==========================================
Files 12 14 +2
Lines 829 855 +26
Branches 90 90
==========================================
+ Hits 825 844 +19
- Misses 4 11 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nbx8
approved these changes
Nov 7, 2025
Collaborator
nbx8
left a comment
There was a problem hiding this comment.
Appendix is a nice addition, thanks.
Contributor
3 tasks
Add CMake configuration for recursive_variant_test Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.