Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates the codebase from a simple package named py-cppmodel to a namespace package xyz-cppmodel that provides the xyz.cppmodel module. The migration includes updating imports, test assertions, and internal string representations to reflect the new namespace structure. Additionally, the dependency lock file has been updated with a newer version of the clang package and consolidated Python version resolution markers.
Changes:
- Renamed package from
py-cppmodeltoxyz-cppmodeland restructured as a namespace package underxyz.cppmodel - Updated all imports and references from
py_cppmodeltoxyz.cppmodelin tests and notebooks - Updated internal
__repr__methods to use the new namespace in their string representations - Upgraded clang dependency from version 14.0 to 21.1.7 in the lock file
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated package name from py-cppmodel to xyz-cppmodel, upgraded clang from 14.0 to 21.1.7, and consolidated Python version resolution markers |
| tests/test_parse_standard_library_includes.py | Updated imports from py_cppmodel to xyz.cppmodel |
| tests/test_cppmodel.py | Updated imports and test assertions to reference xyz.cppmodel instead of py_cppmodel |
| src/xyz/cppmodel.py | Updated all __repr__ methods to use xyz.cppmodel namespace instead of py_cppmodel |
| pyproject.toml | Changed package name to xyz-cppmodel, removed sdist configuration, and updated wheel build to specify namespace package structure |
| Sandbox.ipynb | Updated imports to use xyz.cppmodel and changed kernel display name |
Comments suppressed due to low confidence (1)
src/xyz/cppmodel.py:66
- The string literal "self.type.name" should be formatted to display the actual value. This line should use string formatting similar to line 67, such as:
return "<xyz.cppmodel.FunctionArgument {}>".format(self.type.name)or use an f-string.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "metadata": { | ||
| "kernelspec": { | ||
| "display_name": "Python 3 (ipykernel)", | ||
| "display_name": "py-cppmodel", |
There was a problem hiding this comment.
The kernel display name is set to "py-cppmodel" which references the old package name. For consistency with the namespace migration, consider updating this to "xyz-cppmodel" or a more generic name like "Python 3".
| "display_name": "py-cppmodel", | |
| "display_name": "xyz-cppmodel", |
No description provided.