Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces mypy with ty as the project's type checker and updates dependency management and CI to match.
Changes:
- Update development dependencies in
pyproject.tomlanduv.lockto removemypy(and its supporting packages) and addty. - Configure
tyinpyproject.tomlwith an override forpy_cppmodel.pyto ignoreunresolved-attributediagnostics. - Update local test script and GitHub Actions workflow to run
uv run ty check .instead ofmypy, and simplify the CI Python setup step.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
uv.lock |
Regenerates the lockfile to remove mypy, mypy-extensions, librt, and pathspec, and add ty along with updated dev dependency metadata for the project. |
pyproject.toml |
Switches the dev type-checking dependency from mypy to ty and adds a tool.ty override for py_cppmodel.py to ignore unresolved attribute diagnostics. |
test.macos.sh |
Updates the local test script to run uv run ty check . instead of uv run mypy *.py --check-untyped-defs. |
.github/workflows/python.yml |
Adjusts the CI workflow to use ty for type checking and relies on setup-uv for Python installation without an extra uv python install step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9