Added support for Subresource Integrity#136
Open
meridius wants to merge 5 commits intojanmarek:masterfrom
Open
Added support for Subresource Integrity#136meridius wants to merge 5 commits intojanmarek:masterfrom
meridius wants to merge 5 commits intojanmarek:masterfrom
Conversation
meridius
force-pushed
the
feature/sri
branch
from
9f8cc05 to
5ede9ea
Compare
Collaborator
|
@fprochazka Hi, could you please take a look on this? Or can we help with something? |
Collaborator
|
I like this, but what about the performance of those hashes? Those files can be really big. Shouldn't we compute it on compilation and cache somehow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
Here is a PR to support SRI for included sources as defined (also) on MDN.