Conversation
…booster_video_CTA
|
Parth097
left a comment
Parth097
left a comment
There was a problem hiding this comment.
Just need to look at the disabling of eslint issue, apart from that looks good to me :)
| followedAtLeastOneSoftLink?: boolean; | ||
| } | ||
|
|
||
| // eslint-disable-next-line no-var |
There was a problem hiding this comment.
Is there is good enough reason to disable es-lint here?
Is there another way which es-lint will accept this?
There was a problem hiding this comment.
well, it doesn't like it and is not an issue
There was a problem hiding this comment.
So we enforce es-lint so that we meet some standards within the codebase.
I know it is really annoying but we need to make sure we dont disable eslint otherwise there is no point having it in the first place.
There was a problem hiding this comment.
I have refactored the code to not trigger ESLint for that, funny thing is, this was ESLint suggestion to use global like this.
|
2 participants
No description provided.