791 - School field missing for users after school list update#400
Open
mariusmarin-dev wants to merge 11 commits intomainfrom
Open
791 - School field missing for users after school list update#400mariusmarin-dev wants to merge 11 commits intomainfrom
mariusmarin-dev wants to merge 11 commits intomainfrom
Conversation
Coverage Report
|
The schools_list_2025_december.csv file uses lowercase column names (urn, school_name, postcode, closed, data_source), but the Constants were incorrectly set to uppercase names (URN, EstablishmentName, Postcode, Closed, DataSource). This caused the SchoolListReader to fail with 'unable to ensure the cache has been populated' error. Updated the field name constants to match the CSV headers exactly. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Wrap conditional log.info() calls with log.isInfoEnabled() checks to avoid calling sanitiseExternalLogValue() unnecessarily when the log level is not enabled. This improves performance by preventing method execution for unused log statements. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Parth097
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.