Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return false; | ||
| } | ||
| return true; | ||
| if (!(obj instanceof RegisteredUserDTO other)) return false; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
| return false; | ||
| } | ||
| return true; | ||
| if (!(obj instanceof RegisteredUserDTO other)) return false; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
| return true; | ||
| if (!(obj instanceof RegisteredUserDTO other)) return false; | ||
|
|
||
| return Objects.equals(id, other.id) && |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck> reported by reviewdog 🐶
'&&' should be on a new line.
| if (!(obj instanceof RegisteredUserDTO other)) return false; | ||
|
|
||
| return Objects.equals(id, other.id) && | ||
| Objects.equals(dateOfBirth, other.dateOfBirth) && |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck> reported by reviewdog 🐶
'&&' should be on a new line.
|
|
||
| return Objects.equals(id, other.id) && | ||
| Objects.equals(dateOfBirth, other.dateOfBirth) && | ||
| Objects.equals(email, other.email) && |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck> reported by reviewdog 🐶
'&&' should be on a new line.
| Objects.equals(schoolOther, other.schoolOther) && | ||
| Objects.equals(teacherPending, other.teacherPending) && | ||
| Objects.equals(lastSeen, other.lastSeen) && | ||
| Objects.equals(registeredContexts, other.registeredContexts) && |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck> reported by reviewdog 🐶
'&&' should be on a new line.
| return false; | ||
| } | ||
| return true; | ||
| if (!(obj instanceof RegisteredUser other)) return false; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
| import uk.ac.cam.cl.dtg.isaac.api.GameboardsFacade; | ||
| import uk.ac.cam.cl.dtg.isaac.api.managers.GameManager; | ||
| import uk.ac.cam.cl.dtg.isaac.api.managers.NoWildcardException; | ||
| import uk.ac.cam.cl.dtg.isaac.api.exceptions.NoWildcardException; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'uk.ac.cam.cl.dtg.isaac.api.exceptions.NoWildcardException' import. Should be before 'uk.ac.cam.cl.dtg.isaac.api.managers.GameManager'.
| import uk.ac.cam.cl.dtg.isaac.api.managers.EventBookingManager; | ||
| import uk.ac.cam.cl.dtg.isaac.api.managers.EventBookingUpdateException; | ||
| import uk.ac.cam.cl.dtg.isaac.api.managers.EventIsCancelledException; | ||
| import uk.ac.cam.cl.dtg.isaac.api.exceptions.EventBookingUpdateException; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'uk.ac.cam.cl.dtg.isaac.api.exceptions.EventBookingUpdateException' import. Should be before 'uk.ac.cam.cl.dtg.isaac.api.managers.EventBookingManager'.
| import uk.ac.cam.cl.dtg.isaac.api.managers.EventBookingUpdateException; | ||
| import uk.ac.cam.cl.dtg.isaac.api.managers.EventIsCancelledException; | ||
| import uk.ac.cam.cl.dtg.isaac.api.exceptions.EventBookingUpdateException; | ||
| import uk.ac.cam.cl.dtg.isaac.api.exceptions.EventIsCancelledException; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'uk.ac.cam.cl.dtg.isaac.api.exceptions.EventIsCancelledException' import. Should be before 'uk.ac.cam.cl.dtg.isaac.api.managers.EventBookingManager'.
|
3 participants
No description provided.