Add isArrayOfTrytes method in ValidatorUtil class#70
Open
peter279k wants to merge 1 commit intoiota-php:masterfrom
Open
Add isArrayOfTrytes method in ValidatorUtil class#70peter279k wants to merge 1 commit intoiota-php:masterfrom
peter279k wants to merge 1 commit intoiota-php:masterfrom
Conversation
Contributor
Author
|
@Techworker, please review this PR. Thanks. |
Techworker
reviewed
Oct 1, 2018
Member
Techworker
left a comment
Techworker
left a comment
There was a problem hiding this comment.
I don't see why you added the 2673 as a required length. The method is called isArrayOfTrytes and a trytestring does not necessarily need to be 2673 trytes long.
Contributor
Author
|
Hi @Techworker, thank you for your reply. Is this unnecessary? Thanks. |
Member
|
I think its unnecessary |
Contributor
Author
|
Hi @Techworker, thank you for your reply. Do you mean I remove this It makes sense I think. I will try that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isArrayOfTrytesmethod to validate the array of trytes.