refactor: timeout refactor to use CLI option value#86
refactor: timeout refactor to use CLI option value#86etiennedm wants to merge 5 commits intointercreate:mainfrom
Conversation
|
I'm assuming the linting fails because it's not using the updated version of smpclient. It works locally. Any trick here to make it work/test it is ok before bumping the version? I tried to specify the dependency as |
Running poetry lock and pushing the changes should work. But the we have to remember to retarget pypi after the upstream is released, which won't be too long. |
|
I'm not sure what needs to be done, I'm not very familiar with poetry. Right now my poetry.lock diff is showing a bunch of changes, and I have I guess the easiest would be to do a release of smpclient once you merge intercreate/smpclient#94, which we could then target in the dependencies of smpmgr? |
Yeah, that's easiest in the sense that it doesn't require coming back to this PR to update the pyproject and lock. |
Delegate default value to the client implementation.
Which can be configure with the '--timeout' option in the root command. It is still possible to provide an additional '--timeout' option that applies specifically to the shell command.
Since all uses are based on options.timeout, rely on the fact that the SMPClient is defaulting to precisely this value by construction.
etiennedm
force-pushed
the
smpmgr-timeout-refactor
branch
from
c306eea to
40a702d
Compare
2 participants
This is to address my comment in #71. Do note that I have not updated the smpclient version in the dependencies. I'm not sure how to do it since I'm guessing it will need a release of smpclient first.
See intercreate/smpclient#94 for the necessary changes in smpclient.