fix: use smpclient upstream mtu defaults#56
Merged
JPHutchins merged 1 commit intomainfrom Aug 11, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes hardcoded MTU defaults (4,096B for serial and 1,024B for UDP) from smpmgr to improve out-of-the-box compatibility. Instead, it defers to smpclient's upstream defaults based on Zephyr's KConfig values.
- Changed the MTU parameter from required integer to optional, allowing None values
- Removed hardcoded 1,024B MTU for UDP transport initialization
- Updated help text to clarify that smpclient upstream values will be used as defaults
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| smpmgr/main.py | Modified MTU option to accept None and updated help text |
| smpmgr/common.py | Updated Options class and removed hardcoded UDP MTU |
Comments suppressed due to low confidence (1)
smpmgr/common.py:65
- The function still references
options.mtuin the serial transport case (not shown in diff), but the MTU type has changed toint | None. This could cause issues if the serial transport code path doesn't handle None values properly.
typer.echo(
davedesro
approved these changes
Aug 9, 2025
aldenhaase
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the 4,096B serial MTU default that Intercreate tends to use internally for fast FW updates or file transfers, and removes the 1,024B UDP MTU.
As more people are using smpmgr, the assumption that users would like to default their USB transport for fast upload/download is leading to preventable frustrations. Some devices, like iFixit FixHub, will see FW upgrade upload speeds drop from ~50KBps to ~10KBps with these defaults (users can provide
--mtu 4096to fix), but we don't expect regular users to be impacted since the vast majority use iFixit-provided SW for FW upgrades. That SW knows the correct buffer sizes for fast USB transfers.To get better "out of the box" compatibility, this PR defers defaults to smpclient, which in turn gets its transport defaults from Zephyr's upstream default KConfigs: https://docs.zephyrproject.org/latest/kconfig.html.
Here are some related issues and discussions: