Skip to content

Block Ticket #5: Log.cs removal blocked on incomplete Ticket #2 migration#175

Draft
Copilot wants to merge 1 commit intomasterfrom
copilot/remove-old-log-class
Draft

Block Ticket #5: Log.cs removal blocked on incomplete Ticket #2 migration#175
Copilot wants to merge 1 commit intomasterfrom
copilot/remove-old-log-class

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

Ticket #5 requires removal of Log.cs after all legacy Log calls are migrated to ILogger (Tickets #2-#3). Analysis shows Ticket #2 is incomplete.

Findings

Blocking Issue: 2,023 active Log.* calls remain across 219 files.

# Expected: 0 occurrences
# Actual:
Log.Debug:     1,235 calls
Log.Exception:   408 calls  
Log.Verbose:     301 calls
Log.Error:        61 calls
Log.Warn:         27 calls
Log.Info:         12 calls

Most impacted files:

  • AnimationPlayer.cs: 107 calls
  • PanelStack.cs: 77 calls
  • TextUtils.cs: 66 calls (static class)
  • TextController.cs: 57 calls
  • ScannerCommon.cs: 55 calls

Impact

Removing Log.cs now would cause immediate build failure in 219 files. ILogger infrastructure exists (LoggingConfiguration.cs) but migration is ~10% complete.

Resolution Path

Estimated effort to unblock: 60-80 hours to migrate remaining calls.

File complexity breakdown:

  • 43 simple files (1-3 calls each): ~4 hours
  • 110 moderate files (4-10 calls): ~16 hours
  • 66 complex files (11+ calls): ~40 hours

Recommendation: Complete Ticket #2 migration before attempting Ticket #5, or pivot to bridge/adapter pattern to maintain backward compatibility during incremental migration.

Original prompt

This section details on the original issue you should resolve

<issue_title>[5] Remove Old Log.cs Class</issue_title>
<issue_description>Estimate: 0.5 days
Sprint: Week 2
Assignee: [Developer]


Description

Remove the legacy Log.cs class after confirming all usages have been migrated to ILogger.

Context

Tasks

  • Search entire solution for Log.Debug, Log.Error, etc.
  • Verify zero occurrences found
  • Delete Libraries\ACATCore\Utility\Log.cs
  • Remove from project files
  • Update any documentation referencing Log class
  • Rebuild solution
  • Run full test suite

Acceptance Criteria

  • Log.cs file deleted
  • ✅ Zero compilation errors
  • ✅ Zero references to old Log class remain
  • ✅ Solution builds successfully
  • ✅ All tests pass
  • ✅ Documentation updated

Validation

# These should return 0 results
grep -r "Log\.Debug" --include="*.cs"
grep -r "Log\.Error" --include="*.cs"
grep -r "Log\.Info" --include="*.cs"
grep -r "using.*Log;" --include="*.cs"

# Verify file doesn't exist
ls Libraries/ACATCore/Utility/Log.cs
# Should return: No such file or directory

Dependencies


🎫 Ticket #6: Analyze XML Configuration Files

Labels: phase-1-foundation, configuration, P1-High, analysis, ai-generated
Estimate: 1 day
Assignee: [Developer]
Sprint: Week 3

Description

Use AI to analyze all XML configuration files in ACAT, document their schemas, and identify migration candidates for JSON conversion.

Context

  • Approximately 20 different XML schemas
  • Various configuration types (Actuators, Scanners, Themes, etc.)
  • Need comprehensive inventory before migration

AI Prompt

Analyze the ACAT repository and provide a comprehensive report on XML configuration files:

1. List all XML files and their purposes
2. Identify distinct schemas/types:
   - ActuatorSettings.xml
   - Scanner configuration XMLs
   - Theme XMLs
   - Animation XMLs (skip - handled in Phase 2)
   - Other configuration files

3. For each schema type:
   - Document the structure
   - Count number of instances
   - Identify complexity level (Simple/Medium/Complex)
   - Suggest JSON schema equivalent
   - Note any special handling needed

4. Generate C# POCO classes for top 5 most common schemas

5. Create priority list for migration:
   - Priority 1: High usage, simple structure
   - Priority 2: Medium usage, medium complexity
   - Priority 3: Low usage or complex structure

Output as markdown report with code samples.

Tasks

  • AI generates analysis report
  • Review and validate findings
  • Document edge cases
  • Create migration priority list
  • Identify risks or blockers
  • Create XML → JSON mapping document

Acceptance Criteria

  • ✅ Complete XML inventory document created
  • ✅ All schema types documented
  • ✅ POCO classes generated for top 5 schemas
  • ✅ Migration priority established
  • ✅ Risk assessment documented
  • ✅ Report stored in docs/xml-migration-analysis.md

Deliverable Structure

# XML Configuration Analysis Report

## Executive Summary
- Total XML files: [count]
- Distinct schemas: [count]
- Total file size: [size]
- Estimated migration effort: [hours]

## Schema Inventory

### 1. ActuatorSettings.xml
- **Purpose:** Configure input devices and switches
- **Instances:** 1 per user profile
- **Complexity:** Medium
- **Priority:** P1 (High usage)
- **Sample:**
```xml
<ActuatorSettings>
  <Actuator name="Keyboard" enabled="true">
    <Switch name="Enter" action="Select" />
  </Actuator>
</ActuatorSettings>

[Continue for all schema types...]

Recommended Migration Order

  1. ActuatorSettings.xml - High usage, well-defined
  2. ThemeSettings.xml - Simple structure
  3. [etc...]

Generated POCO Classes

[Include code samples]


### Dependencies
- None (independent analysis)

### Related Files
- All `*.xml` files in repository

---

## 🎫 Ticket intel/acat#7: Create JSON Schemas for Top 5 Configurations

**Labels:** `phase-1-foundation`, `configuration`, `P1-High`, `ai-generated`  
**Estimate:** 2 days  
**Assignee:** [Developer]  
**Sprint:** Week 3

### Description
Generate JSON schemas and C# POCO classes for the top 5 most-used XML configurations identified in Ticket intel/acat#6.

### Context
- Based on analysis from Ticket intel/acat#6
- Create strongly-typed configuration classes
- Enable IntelliSense in VS Code for JSON editing

### AI Prompt

For each of the top 5 XML configuration schemas in ACAT:

  1. Generate equivale...

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Remove legacy Log.cs class from codebase Block Ticket #5: Log.cs removal blocked on incomplete Ticket #2 migration Feb 6, 2026
Copilot AI requested a review from michaelbeale-IL February 6, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[5] Remove Old Log.cs Class

2 participants