Fix signature of BufferWithSegmentsCollection_init#282
Open
zebreus wants to merge 1 commit intoindygreg:mainfrom
Open
Fix signature of BufferWithSegmentsCollection_init#282zebreus wants to merge 1 commit intoindygreg:mainfrom
zebreus wants to merge 1 commit intoindygreg:mainfrom
Conversation
Author
|
@indygreg Can you take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct signature for
tp_initfunctions has three parameters; but theBufferWithSegmentsCollection_initjust takes two. While most platforms allow calling functions with the wrong number of parameters, WebAssembly only allows calling functions with the correct signature.This PR fixes that issue by adding the missing
PyObject *kwargsparameter toBufferWithSegmentsCollection_init