Potential fix for code scanning alert no. 50: Workflow does not contain permissions#124
Merged
Potential fix for code scanning alert no. 50: Workflow does not contain permissions#124
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit permissions blocks at the workflow root and for individual jobs to satisfy code scanning alert no. 50 by granting only the minimum required permissions.
- Introduces a root-level
permissionsblock withcontents: read - Specifies job-level permissions for test, semantic-release, GitHub publish, and NuGet publish jobs
- Limits each job to only the permissions needed for its tasks
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:14
- The
permissionsblock for thetestjob duplicates the root-levelcontents: read. You can remove this block to reduce redundancy since jobs inherit root permissions.
permissions:
.github/workflows/release.yml:65
- [nitpick] The job name "Publish to Github" should use the correct capitalization of the GitHub brand ("GitHub").
name: Publish to Github
.github/workflows/release.yml:85
- [nitpick] The job name "Publish to Nuget" should use the correct branding capitalization ("NuGet").
name: Publish to Nuget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/improvgroup/sharedcode/security/code-scanning/50
To fix the issue, we will add a
permissionsblock to the root of the workflow and to individual jobs where necessary. This ensures that each job has the minimum required permissions for its tasks. For example:testjob does not require any write permissions, so it will be limited tocontents: read.semantic-releasejob requires write permissions forcontentsto create tags and releases.github-publishandnuget-publishjobs requirepackages: writeto push packages.We will add these permissions explicitly to the workflow and jobs.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.