IBX-10734: simplexml_load_string() throws an exception on ezselection fields when using libxml2 2.13.8 and higher#706
Open
IBX-10734: simplexml_load_string() throws an exception on ezselection fields when using libxml2 2.13.8 and higher#706
Conversation
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
|
Steveb-p
approved these changes
Feb 5, 2026
Contributor
Steveb-p
left a comment
Steveb-p
left a comment
There was a problem hiding this comment.
Bonus points if you provide a unit test.
konradoboza
reviewed
Feb 5, 2026
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Unit test should be provided, it should be fairly easy to AI-generate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When creating new content type and adding selection field, it immediately tries to parse this field through converter, obviously on initial setup this field will be empty.
On certain versions of
libxml2like2.13.8, functionsimplexml_load_stringwill throw an exception when the parameter is null.I've added a check on
$mlData->dataTextto avoid this exception.