Added native_function_invocation for @compiler_optimized functions#20
Open
Added native_function_invocation for @compiler_optimized functions#20
native_function_invocation for @compiler_optimized functions#20Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a risky rule that will prefix all global, compiler optimized (generating simplified OPCode operations under certain conditions) function calls with
\https://cs.symfony.com/doc/rules/function_notation/native_function_invocation.html
For example, it prefixes all
sprintfcalls, because in newer versions of PHP compiler can recognize that no special processing is actually being done (for example,"Something %s" foois used as string) and can be replaced with interpolation OPCode instead).For QA:
Documentation: