Bumped PHP CS Fixer to v3.89.1 and updated deprecated rules

[alongosz]

🎫 Issue	n/a

Related PRs:

• [DO NOT MERGE][PREVIEW][CS] Aligned codebase with ibexa/code-style#18 admin-ui#1755
• [DO NOT MERGE][PREVIEW][CS] Aligned codebase with ibexa/code-style#18 core#668
• [CS] Bumped Ibexa Code Style to v2.1.0 core#665
• [DO NOT MERGE][PREVIEW][CS] Bumped Ibexa Code Style to ^2.2.x-dev core#666
• [DO NOT MERGE][PREVIEW][CS] Bumped Ibexa Code Style to ^2.2.x-dev admin-ui#1756

Description:

Yet another pre-release step for 2.2.0.

Bumped PHP CS Fixer fixed version constraint to the latest v3.89.1.

We had some deprecated rules. New fixer introduced @PER-CS2x0 set in place of @PER-CS2.0 one.
Also there were some pre-existing deprecations for v3.75.0:

- Rule "braces" is deprecated. Use "single_space_around_construct", "control_structure_braces", "control_structure_continuation_position", "declare_parentheses", "no_multiple_statements_per_line", "braces_position", "statement_indentation" and "no_extra_blank_lines" instead.
- Rule "native_function_type_declaration_casing" is deprecated. Use "native_type_declaration_casing" instead.
- Rule "new_with_braces" is deprecated. Use "new_with_parentheses" instead.
- Rule "no_unneeded_curly_braces" is deprecated. Use "no_unneeded_braces" instead.

It was quite complicated for the braces, so hopefully I got it right.

Seems like some rules conflict with each other:

1. braces_position and single_line_empty_body. The former one creates:

   function foo(): void {
   }

   however the latter one overrides it:

    function foo(): void {}

2. blank_line_between_import_groups and no_extra_blank_lines. The former one:

   use Ibexa\Class\FQCN;
   
   use function foo;
   
   use Symfony\Class\FQCN;

   while the latter one refactors it to:

    use Ibexa\Class\FQCN;
    use function foo;
    use Symfony\Class\FQCN;

Defined explicitly in an ordered fashion (the last one seems to take precedence) for Ibexa 4.6 Rule Set. Ibexa 5.0 Rule Set relies on @PER-CS2x0 which sets these by default (experimented last week on admin-ui changes for main and it seemed not to produce any CS issues).

Tip

Note that the above are non-deterministic and depend on some factors unknown to me. ATM CI was not showing these issues, however locally without defining explicit order for these rules, I got CS issues reported.

[konradoboza]

+1 but would be nice to see this "in action" to verify if there are rules that don't fit.

[alongosz]

+1 but would be nice to see this "in action" to verify if there are rules that don't fit.

@konradoboza yeah, I'd like that too, but it's a bit difficult ATM, because of removal of FQCNs from the doc and multiline parameters. Applying 2.2.x-dev on core:main yields 2254 changed files due to #15, #16, and #13.

Maybe I'll try to cherry-pick this to 2.1.0 tag locally... :/

[konradoboza]

Maybe I'll try to cherry-pick this to 2.1.0 tag locally... :/

Didn't aim to suggest any additional work. We can iterate and decide once we start using bumped version.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud