Skip to content

Conversation

@jjeliga
Copy link
Contributor

@jjeliga jjeliga commented Feb 2, 2026

Summary

When updating agents added using github url via agentstack agent update ..., the code now correctly recognizes the github origin and shows a list of tags to choose if available. Similar logic existed in the "add" command, where the functionality has been improved to allow tag selection right away when inputting a bare github url

Linked Issues

Closes #1788

Documentation

  • No Docs Needed:

Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 2, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jjeliga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the agentstack agent update command, specifically enhancing its ability to manage agents sourced from GitHub repositories. The changes ensure more accurate identification of GitHub origins, provide users with an interactive selection of available tags for updates, and standardize the internal handling of agent source information.

Highlights

  • Improved GitHub Origin Recognition: The agentstack agent update command now more accurately recognizes GitHub origins, including those prefixed with git+.
  • Interactive Tag Selection for Updates: When updating GitHub-hosted agents, users are now presented with an interactive list of available tags to choose from.
  • Standardized Origin Handling: The internal logic for handling agent source information has been standardized to consistently use provider.origin instead of provider.source.
  • Docstring Cleanup: The [aliases: install] entry has been removed from the add_agent command's docstring.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jjeliga jjeliga requested a review from jezekra1 February 2, 2026 15:19
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the agent update logic to use provider.origin instead of provider.source for identifying GitHub-based agents. This is a good improvement for consistency and correctness. However, I've identified a critical issue in the new regular expression for parsing GitHub URLs. It would fail for standard https:// URLs and also lacks support for enterprise GitHub instances, a feature documented elsewhere. I've provided a code suggestion to address these issues.

Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 2, 2026
@jjeliga jjeliga changed the title extracting location info from origin CLI - Improve agentstack update UX Feb 3, 2026
if version is None and path is None:
async with httpx.AsyncClient() as client:
response = await client.get(
f"https://api.github.com/repos/{owner}/{repo}/tags",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github api has strict rate limits for unauthenticated users (only 60 requests per hour!):
https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28

It's based on IP address so it will break for users under NAT who share the same IP (very common scenario).

Consider using unauthenticated approach using the internal github.com requests not api.github.com, similar to:

https://github.com/i-am-bee/agentstack/blob/main/apps/agentstack-server/src/agentstack_server/utils/github.py#L180

Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 6, 2026
Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

CLI - Improve agentstack update UX

2 participants