-
Notifications
You must be signed in to change notification settings - Fork 139
CLI - Improve agentstack update UX
#1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
Summary of ChangesHello @jjeliga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly refactors the agent update logic to use provider.origin instead of provider.source for identifying GitHub-based agents. This is a good improvement for consistency and correctness. However, I've identified a critical issue in the new regular expression for parsing GitHub URLs. It would fail for standard https:// URLs and also lacks support for enterprise GitHub instances, a feature documented elsewhere. I've provided a code suggestion to address these issues.
Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
agentstack update UX
| if version is None and path is None: | ||
| async with httpx.AsyncClient() as client: | ||
| response = await client.get( | ||
| f"https://api.github.com/repos/{owner}/{repo}/tags", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github api has strict rate limits for unauthenticated users (only 60 requests per hour!):
https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28
It's based on IP address so it will break for users under NAT who share the same IP (very common scenario).
Consider using unauthenticated approach using the internal github.com requests not api.github.com, similar to:
Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
Summary
When updating agents added using github url via
agentstack agent update ..., the code now correctly recognizes the github origin and shows a list of tags to choose if available. Similar logic existed in the "add" command, where the functionality has been improved to allow tag selection right away when inputting a bare github urlLinked Issues
Closes #1788
Documentation