Open
Conversation
Clang has a different behaviour than GCC when it comes to inlining functions.
Sadly Clang identifies itself as __GNUC__, hence the define to prevent non-GCC
compilers to use the inline keyword didn't work.
This commit solves the problem with adding an additional check to the define,
that the compiler isn't Clang.
During compilation you get warnings like:
In file included from linux_sigar.c:30:
../../../include/sigar_util.h:80:20: warning: inline function 'sigar_skip_token' is not defined
[-Wundefined-inline]
SIGAR_INLINE char *sigar_skip_token(char *p);
^
linux_sigar.c:137:24: note: used here
if ((ptr = sigar_skip_token(ptr))) {
^
Which end up in an error like:
libtool: link: clang -g -O2 -o .libs/cpuinfo cpuinfo.o ../src/.libs/libsigar.so
../src/.libs/libsigar.so: undefined reference to `sigar_skip_token'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
lizhanyin
added a commit
to lizhanyin/sigar
that referenced
this pull request
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang has a different behaviour than GCC when it comes to inlining functions.
Sadly Clang identifies itself as GNUC, hence the define to prevent non-GCC
compilers to use the inline keyword didn't work.
This commit solves the problem with adding an additional check to the define,
that the compiler isn't Clang.
During compilation you get warnings like:
Which end up in an error like: