Additional fixes in Type.php#8
Merged
ralflang merged 2 commits intohorde:FRAMEWORK_6_0from Jun 23, 2025
Merged
Conversation
ralflang
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not commit directly (no access for some reason).
There are many more places that depend on
Horde_Form_Typewhich have to be modified. Only to be modified yet again for V3.But to actually make use of the returned error messages all dependents have to start using
getMessage().To simplify the code I propose to add (and use) a method like this to
Horde_Form_Typeclass:Any objections?