getType(): flatten named parameters before calling init()

[amulet1]

This is a proposed fix to #12:

I made getType() method private as it looks like this is not used anywhere outside of Horde_Form. And this is the only place where the named parameters could be passed (there is also two direct calls to init() in Horde_Form_Type_datetime, but these are internal and they use positional parameters already).

I am using params from value returned by about(). I had to adjust it in a few places (non-critical change) to match original parameters names.

Later we could also add support for defaults by adding them to array returned by about() (and should not this method be static?). It is also possible to implement parameters type checks.

With the migration to V3 this will all be reworked, anyway.

[amulet1]

See also #11 and horde/turba#21.

[amulet1]

@TDannhauer Please merge.

[amulet1]

See also #11 and horde/turba#21.

[TDannhauer]

hi @amulet1 , is your proposal following approach A) or B) from the issue?

I suggest we have a short call - maybe tomorrow - to discuss the approaches , pros and cons to select a road to go.
Sorry, as I am not a native PHP developer, i can not discuss solely based on code...

[amulet1]

I chose approach (A) due to several reasons:

• one simple change in getType(), and it also allows to simplify init() methods
• no need to undo anything
• possibility to add support for default values (and further simplify init())
• possibility to add parameter type checks

[TDannhauer]

where is the link logic now located if not longer in this variable?

[amulet1]

The LinkVariable is basically a refactoring of Horde_Form_Type_link.
The rendering logic is (oddly) in https://github.com/horde/Core/blob/FRAMEWORK_6_0/lib/Horde/Core/Ui/VarRenderer/Html.php. I am actually planning to move/migrate it to V3 classes (this was stalled but hopefully it can be revived right after the next beta release). This would actually make things easier to maintain.

Note, V3 classes are not used anywhere yet (except for my test setup). When this PR is updated, I will ypdate the V3_variable branch accordingly to help with V3 testing. However, at this time we should focus on making all the recent fixes available to everyone. Refactoring and major code improvements should be our second priority.

[TDannhauer]

hm I see my folder names via Exchange ActiveSync being suffixed with [1] - might this be a consequence of the changes as well @amulet1 ?

edit: visible just in MS outlook - might be a client issue

[amulet1]

hm I see my folder names via Exchange ActiveSync being suffixed with [1] - might this be a consequence of the changes as well @amulet1 ?

edit: visible just in MS outlook - might be a client issue

Changes in the PR should not break anything existing.