fix: Deprecated strlen(null) in Redis Hashtable on PHP 8.1+#44
Open
jcdelepine wants to merge 1 commit intohorde:FRAMEWORK_6_0from
Open
fix: Deprecated strlen(null) in Redis Hashtable on PHP 8.1+#44jcdelepine wants to merge 1 commit intohorde:FRAMEWORK_6_0from
jcdelepine wants to merge 1 commit intohorde:FRAMEWORK_6_0from
Conversation
### Problem On PHP 8.1+, calling `strlen(null)` raises a deprecation warning in Redis Hashtable configuration when no password is set. ### Solution Replaced `strlen()` check with `!empty()` to ensure proper handling of null/empty passwords while preserving previous behavior. ### Compatibility - No change in functionality. - Tested on PHP 8.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On PHP 8.1+, calling
strlen(null)raises a deprecation warning in Redis Hashtable configuration when no password is set.Solution
Replaced
strlen()check with!empty()to ensure proper handling of null/empty passwords while preserving previous behavior.Compatibility