Conversation
| private List<OSCPacketListener> packetListeners; | ||
| private SocketAddress local; | ||
| private SocketAddress remote; | ||
| private SocketAddress localSocketAddress; |
There was a problem hiding this comment.
Rename of the internal variable because the setters were not named correctly, and the code checker didn't recognize them correctly and threw HiddenField alerts when using this.<varname> = <varname>; instead of arbitrary different name.
(same for remote address, and same for PortOutBuilder class)
| <module name="HiddenField"> | ||
| <property name="ignoreConstructorParameter" value="true"/> | ||
| <property name="ignoreSetter" value="true"/> | ||
| <property name="setterCanReturnItsClass" value="true" /> |
There was a problem hiding this comment.
Helps the codestyle checker to correctly recognize setters that return the class.
|
Notes for review:
|
closes #66
@nsowen @hoijui new MR because i can't modify the source branch of the existing one