Auto migrate hashicorp to ibm #189
Open
+665
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds updateLicenseHolder() function to auto-detect and replace HashiCorp copyright holders - Detects 'HashiCorp, Inc.', 'HashiCorp Inc', and 'HashiCorp' patterns - Works with all comment styles (Go, Python, Shell, C-style, HTML) - Preserves existing year information and updates to current format - Modifies processFile() to attempt holder update for files with existing licenses - Adds comprehensive test coverage with 14 test cases - Updates README with automatic migration feature documentation This feature ensures old HashiCorp headers are automatically caught and updated, preventing regressions from old PRs or copied code.
- Remove verbose flag check so files are always displayed during updates - Show '(copyright holder updated)' when HashiCorp->IBM migration happens - Show '(license header added)' when new headers are added - Improves visibility in both --plan and regular mode
- Add error check for os.Remove in test to satisfy errcheck linter - Remove ineffectual assignment to modified variable
- Add wouldUpdateLicenseHolder() function for dry-run detection of copyright holder changes - Modify processFile() to check for potential holder updates in checkonly/plan mode - Add test coverage for wouldUpdateLicenseHolder() function - Now --plan flag shows both missing headers and files that would have copyright holders updated from HashiCorp to IBM - Fix golangci-lint issues (errcheck and ineffassign) - Update .copywrite.hcl copyright_year configuration - Tested: reduced false positives from 29 to 5 files, correctly shows holder updates
- Add error check for tmpfile.Close() in TestWouldUpdateLicenseHolder
CreatorHead
force-pushed
the
auto-migrate-hashicorp-to-ibm
branch
from
d7cdc4c to
19c688d
Compare
radeksimko
suggested changes
Feb 6, 2026
Comment on lines
+276
to
+280
| updated, err := updateLicenseHolder(f.path, f.mode, license) | ||
| if err != nil { | ||
| logger.Printf("%s: %v", f.path, err) | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
I'm not sure why this is only getting triggered in this branch/PR but when I run copywrite headers against a repository with a directory in it - perhaps a directory name of a specific pattern - it fails here with the following error:
Error: read releases/testdata/mock_api_tf_0_14_with_prereleases/terraform/0.14.11: is a directory
https://github.com/hashicorp/hc-install
It puzzles me why does a directory even get this far past
Lines 280 to 282 in 0be59e7
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this:
Solution: Added isDirectory() helper using os.Stat() (follows symlinks) in both migration functions. Now directories are skipped gracefully instead of crashing.
Commit: 0a3f20d - please test with the updated branch.
- Add isDirectory helper function to check for directories and symlinks to directories - Use helper in updateLicenseHolder and wouldUpdateLicenseHolder functions - Resolves issue where filepath.Walk's fi.IsDir() misses symlinks to directories - Fixes error: 'read path: is a directory' reported in PR feedback This prevents crashes when processing repositories with symbolic links that point to directories, such as version directories in test fixtures.
radeksimko
reviewed
Feb 6, 2026
Member
radeksimko
left a comment
radeksimko
left a comment
There was a problem hiding this comment.
The last revision resolves the problem with directories 👍🏻 - my only remaining ask would be to add a test case for this, to ensure it doesn't break with any future updates. Would you mind adding one?
- Add TestIsDirectory to test helper function for detecting directories and symlinks - Add TestUpdateLicenseHolderSkipsDirectories to verify updateLicenseHolder skips directories - Add TestWouldUpdateLicenseHolderSkipsDirectories to verify wouldUpdateLicenseHolder skips directories - Add TestDirectorySkippingRegressionTest as integration test for the original crash scenario - Tests cover symlinks to directories which was the root cause of 'is a directory' error - Ensures the fix in commit 0a3f20d remains stable and prevents future regressions
Check error return value from tmpfile.Close() in TestIsDirectory to satisfy errcheck linter.
radeksimko
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Problem: When migrating from HashiCorp to IBM, old copyright headers with "HashiCorp, Inc.", "HashiCorp Inc", or "HashiCorp" needed to be manually updated, leading to inconsistency and potential regressions from old PRs or copied code.
Solution: Added automatic detection and replacement of HashiCorp copyright holders to IBM Corp format.
Why this approach:
🔗 External Links
https://hashicorp.atlassian.net/browse/CCEN-223
👍 Definition of Done
🤔 Can be merged upon approval? [Yes]
✅
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.