Conversation
yaocw2020
requested review from
LucasSaintarbor,
guangbochen and
vickyhella
yaocw2020
force-pushed
the
best-practice
branch
from
76bc618 to
398e42b
Compare
✅ Deploy Preview for harvester-preview ready!
|
yaocw2020
force-pushed
the
best-practice
branch
from
398e42b to
6f26b5a
Compare
yaocw2020
force-pushed
the
best-practice
branch
from
1fa7381 to
d8884ac
Compare
yaocw2020
force-pushed
the
best-practice
branch
from
d8884ac to
4044bcc
Compare
LucasSaintarbor
left a comment
LucasSaintarbor
left a comment
There was a problem hiding this comment.
Small NITs. LGTM, thanks!
|
the best practice only covers what is needed from the routing/switching end. Though this is a good reference we should ideally leave it up to the end users. would it make sense to also have more info on how to configure cluster networks for different interfaces, and then created the VM networks? Some sample |
Good suggestion. I would add some reference cases about cluster networks and VM networks. |
w13915984028
left a comment
w13915984028
left a comment
There was a problem hiding this comment.
It is great to have such documents. Besides the current wonderful commit, also some suggestions:
There are a few traditional network setting scenarios in Harvester:
(1) All flat network, no isolation (home lab /trial)
(2) All vlan network, even for management, dedicated nics (production deployment)
(3) Mixed un-tagged and tagged network; only 1 nic (home lab /trial/poc...)
(4) Mixed un-tagged and tagged network; multi nics (poc ...)
This doc covers (4); we may also list (1)~(3) and update them now or future. thanks.
|
@w13915984028 Can you help finalize this PR by creating pages in https://github.com/harvester/docs/tree/main/versioned_docs/version-v1.2 as well? I guess at the writing time, the v1.2 was not released yet. |
|
This is not part of this PR but in deep-dive.md, line 110, there is a typo, where any chance we can please fix this too? |
Signed-off-by: yaocw2020 <yaocanwu@gmail.com> Co-authored-by: vickyhella <vickyhella@hotmail.com>
Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
w13915984028
force-pushed
the
best-practice
branch
from
f7eb86c to
bff2239
Compare
Signed-off-by: Jian Wang <w13915984028@gmail.com>
w13915984028
force-pushed
the
best-practice
branch
from
bff2239 to
901f960
Compare
|
@bk201 This PR is ready for final merging now. Thanks again for @yaocw2020 's great effort. |
yaocw2020
dismissed stale reviews from w13915984028, ibrokethecloud, and LucasSaintarbor
via
901f960
8 participants
No description provided.