Apply Standard Js Hapiness norm and module tracking#213
Apply Standard Js Hapiness norm and module tracking#213fdaugan wants to merge 5 commits intoguybedford:masterfrom
Conversation
To be able to unload the CSS from requireJS, the related module must be stored in the created 'link'. Use the standard requirejs "'data-requiremodule'" attribute.
Add 'data-requiremodule' to be able to unload the CSS
|
@fabdouglas First of al thank you for this PR. I've recently joined as maintainer of this module, so I will be responsible in future for PRs, issues discussions, etc. Nevertheless,
I think we may do this, but in a bit different manner. First have a look to my PR: #222 - I added config file, to at least remain existed code indentation/spacing. Later on, we need to create dedicated PR for ALL files in codebase. And I will do it, and for sure will check code standards u mentioned.
This lines are definitely not related to spacing/indentation. I don't know original nature of bug/behavior u mention in 2nd part of this PR description, but if u provide code examples, how u unload css module, it would help me to get into that faster.
Considering all above, it's very likely, that I will close this PR, but I will recreate new one later, with your suggestion. If during the week, will be no reply from @fabdouglas I will do this for sure. cc/ @pavlo.savushchyk |

Apply Standard Js Hapiness norme
@see http://standardjs.com/rules.html
To be able to unload the CSS from requireJS, the related module must be stored in the created 'link'.
Use the standard requirejs "'data-requiremodule'" attribute.